Set a default logger routed to the error log#35
Open
deviantintegral wants to merge 5 commits intoenygma:masterfrom
Open
Set a default logger routed to the error log#35deviantintegral wants to merge 5 commits intoenygma:masterfrom
deviantintegral wants to merge 5 commits intoenygma:masterfrom
Conversation
Author
|
PHP 5.3 was EOL as of August last year. The tests are failing because of short array syntax. Can we get that removed from the travis config? Or is there some specific reason we need to support 5.3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other option would be to put the logger in the constructor, but I imagine in most scenarios the PHP error log is fine as a default.