Skip to content

mcp: fix github public server tests after they renamed their tools#1326

Merged
Xunzhuo merged 3 commits into
envoyproxy:mainfrom
nacx:fix-public-mcp
Oct 10, 2025
Merged

mcp: fix github public server tests after they renamed their tools#1326
Xunzhuo merged 3 commits into
envoyproxy:mainfrom
nacx:fix-public-mcp

Conversation

@nacx
Copy link
Copy Markdown
Member

@nacx nacx commented Oct 10, 2025

Description

The pull request tools in the GitHub MCP server got renamed: github/github-mcp-server#1172
This caused the extproc tests that used it to fail (we see this in many CI failed tests)

This PR fixes it and also updates the example regexps to have the examples still match the same tools as before.

Related Issues/PRs (if applicable)

github/github-mcp-server#1172

Special notes for reviewers (if applicable)

N/A

@nacx nacx requested a review from a team as a code owner October 10, 2025 12:08
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (791036a) to head (5c117d2).

❌ Your project status has failed because the head coverage (77.58%) is below the target coverage (86.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   77.57%   77.58%           
=======================================
  Files         123      123           
  Lines       15768    15768           
=======================================
+ Hits        12232    12233    +1     
+ Misses       2909     2908    -1     
  Partials      627      627           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
nacx added 2 commits October 10, 2025 14:18
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
Signed-off-by: Ignasi Barrera <ignasi@tetrate.io>
@Xunzhuo
Copy link
Copy Markdown
Member

Xunzhuo commented Oct 10, 2025

thanks!

@Xunzhuo Xunzhuo merged commit e3bf5fd into envoyproxy:main Oct 10, 2025
31 checks passed
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
…nvoyproxy#1326)

Signed-off-by: Hrushikesh Patil <hrushikesh.patil@nutanix.com>
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
…nvoyproxy#1326)

Signed-off-by: Hrushikesh Patil <hrushikesh.patil@nutanix.com>
nutanix-Hrushikesh pushed a commit to nutanix-Hrushikesh/ai-gateway that referenced this pull request Oct 16, 2025
…nvoyproxy#1326)

Signed-off-by: Hrushikesh Patil <hrushikesh.patil@nutanix.com>
missBerg pushed a commit to missBerg/ai-gateway that referenced this pull request Dec 20, 2025
…nvoyproxy#1326)

Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants