fix: int32→int64 BSON property values + CREATE OR REPLACE PAGE UUID reuse#31
Open
fix: int32→int64 BSON property values + CREATE OR REPLACE PAGE UUID reuse#31
Conversation
…D reuse BSON int32→int64: - All property values in writer serialization changed from int32 to int64 to match Studio Pro's expected BSON types - Array version markers (int32(2), int32(3)) preserved as int32 - Fixes Studio Pro crash: "Sequence contains no matching element" in MprProperty..ctor when type cache expects int64 but finds int32 CREATE OR REPLACE PAGE: - Reuses existing page UUID and calls UpdatePage instead of DeletePage+ CreatePage, producing git "Modified" diff instead of "Deleted+Added" - Prevents RevStatusCache crash when parsing deleted mxunit base files BSON roundtrip test baseline: - Add golden mxunit files for roundtrip testing (pages, microflows, enums) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Revert array markers from int64 back to int32 (verified against Studio Pro BSON) - Remove 26-line debug log block in writer_widgets_custom.go - Fix 4 comments that said int64 but code correctly uses int32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Studio Pro crashes with
Sequence contains no matching elementwhen BSON int32 doesn't match expected int64.Test plan
go buildpassesgo test ./sdk/mpr/passes