Skip to content

Conversation

@LagoLunatic
Copy link
Collaborator

Fixes #311

@dbalatoni13
Copy link
Contributor

I just noticed that now when you enter the symbol mapping view while you have a filter, the filter stays there on the other side. I think we might need considerations about this because you usually want to search for something and then map to something different, right?

@LagoLunatic
Copy link
Collaborator Author

I just noticed that now when you enter the symbol mapping view while you have a filter, the filter stays there on the other side. I think we might need considerations about this because you usually want to search for something and then map to something different, right?

Updated so that the mapping filter is stored separately. I also cleared the mapping filter when switching between views, so the mapping filter won't be preserved across mapping two different functions, it will always be blank when you start mapping to avoid confusion. But the regular non-mapping filter is still preserved when switching views.

(By the way, it seems the version of objdiff on decomp.me already had the behavior of the filter being shared between mapping and non-mapping. Not sure how to modify that one though.)

@dbalatoni13
Copy link
Contributor

Sounds great, going to test it right away

@tomsons26
Copy link
Contributor

tomsons26 commented Jan 5, 2026

Works as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The symbol filter doesn't work in the symbol mapping view

3 participants