Preserve empty REL section slots dropped by mwld#145
Open
Jovinull wants to merge 1 commit into
Open
Conversation
Some games reserve an empty section slot before .text. mwld drops it during the partial link because nothing lands in it, so the object has .text at index 1 while the original REL has it at 2, and every later section is written one index low. prologSection, epilogSection and unresolvedSection shift with them, which leaves rel info unable to read the REL that rel make just wrote. Fill in match_section_index, which was a stub returning the ELF index with the working version commented out below it, and carry the same mapping through write_rel: sections are now placed at the index they occupy in the original REL, and the slots mwld dropped are written back as empty. The map is only built when it differs from the ELF's own indices, so RELs without a dropped slot take the same path as before. Fixes the 17 RELs in Sonic Heroes (G9SE8P), which now match the originals byte for byte.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some games reserve an empty section slot before .text. mwld drops it during the partial link because nothing lands in it, so the object has .text at index 1 while the original REL has it at 2, and every later section is written one index low. prologSection, epilogSection and unresolvedSection shift with them, which leaves rel info unable to read the REL that rel make just wrote.
Fill in match_section_index, which was a stub returning the ELF index with the working version commented out below it, and carry the same mapping through write_rel: sections are now placed at the index they occupy in the original REL, and the slots mwld dropped are written back as empty. The map is only built when it differs from the ELF's own indices, so RELs without a dropped slot take the same path as before.
Fixes the 17 RELs in Sonic Heroes (G9SE8P), which now match the originals byte for byte.
#144