Add .wait_ready to parser for clean server disconnects#3690
Merged
Conversation
3 tasks
LittleChiu
added a commit
to LittleChiu/ai-pr-reviewer
that referenced
this pull request
May 29, 2026
跑了三档复杂度的真实 PR,作为 demo 视频素材与质量证据: | 编号 | PR | 文件 | 用时 | LLM 调用 | tokens | risks/sug | |---|---|--:|--:|--:|--:|--:| | A | fastapi/fastapi#15603 (依赖升级) | 6 | 11s | 1 | 1.5K | 0/0 | | B | encode/httpx#3690 (新 API) | 4 | 245s | 3 | 7.8K | 6/4 | | C | encode/httpx#3670 (重构) | 5 | 78s | 3 | 11.5K | 7/4 | 亮点: - A 演示 triage 阶段对 lockfile/依赖性变更的'整体跳过', 仅 1 次 LLM 调用、~1.5K tokens 完成 - C 抓到的 HIGH/bug 是真问题:对普通文件对象调 'await self._fin.close()' 会抛 TypeError,带 high confidence 与具体修改方向 - 每条 risk 都附 file/line/severity/category/confidence,可直接采纳 每份样例同时存原始 JSON,评委可复现(同 commit SHA + 同 prompt + temp 0.2)。
LittleChiu
added a commit
to LittleChiu/ai-pr-reviewer
that referenced
this pull request
May 29, 2026
跑了三档复杂度的真实 PR,作为 demo 视频素材与质量证据: | 编号 | PR | 文件 | 用时 | LLM 调用 | tokens | risks/sug | |---|---|--:|--:|--:|--:|--:| | A | fastapi/fastapi#15603 (依赖升级) | 6 | 11s | 1 | 1.5K | 0/0 | | B | encode/httpx#3690 (新 API) | 4 | 245s | 3 | 7.8K | 6/4 | | C | encode/httpx#3670 (重构) | 5 | 78s | 3 | 11.5K | 7/4 | 亮点: - A 演示 triage 阶段对 lockfile/依赖性变更的'整体跳过', 仅 1 次 LLM 调用、~1.5K tokens 完成 - C 抓到的 HIGH/bug 是真问题:对普通文件对象调 'await self._fin.close()' 会抛 TypeError,带 high confidence 与具体修改方向 - 每条 risk 都附 file/line/severity/category/confidence,可直接采纳 每份样例同时存原始 JSON,评委可复现(同 commit SHA + 同 prompt + temp 0.2)。
LittleChiu
added a commit
to LittleChiu/ai-pr-reviewer
that referenced
this pull request
May 30, 2026
跑了三档复杂度的真实 PR,作为 demo 视频素材与质量证据: | 编号 | PR | 文件 | 用时 | LLM 调用 | tokens | risks/sug | |---|---|--:|--:|--:|--:|--:| | A | fastapi/fastapi#15603 (依赖升级) | 6 | 11s | 1 | 1.5K | 0/0 | | B | encode/httpx#3690 (新 API) | 4 | 245s | 3 | 7.8K | 6/4 | | C | encode/httpx#3670 (重构) | 5 | 78s | 3 | 11.5K | 7/4 | 亮点: - A 演示 triage 阶段对 lockfile/依赖性变更的'整体跳过', 仅 1 次 LLM 调用、~1.5K tokens 完成 - C 抓到的 HIGH/bug 是真问题:对普通文件对象调 'await self._fin.close()' 会抛 TypeError,带 high confidence 与具体修改方向 - 每条 risk 都附 file/line/severity/category/confidence,可直接采纳 每份样例同时存原始 JSON,评委可复现(同 commit SHA + 同 prompt + temp 0.2)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.wait_ready()toHTTPParser...We need this in order to differentiate between clean disconnects at the start of a new request/response cycle, rather than a
ProtocolErrorwhile callingrecv_method_line().