Normalize TLS server hostnames#1086
Closed
bubaizhanshen wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1063.
Hostnames may include a trailing dot to mark a fully qualified domain name. Passing that dotted hostname to TLS verification can cause a certificate hostname mismatch even when the certificate is valid for the same hostname without the final dot.
This strips trailing dots from
server_hostnamein the sync, anyio, and trio TLS backends before passing the name to the TLS layer.Tests:
pytest tests/test_ssl.pypytest tests/_sync/test_connection.py tests/_async/test_connection.pyruff check httpcore/_ssl.py httpcore/_backends/sync.py httpcore/_backends/anyio.py httpcore/_backends/trio.py tests/test_ssl.pyruff format --check httpcore/_ssl.py httpcore/_backends/sync.py httpcore/_backends/anyio.py httpcore/_backends/trio.py tests/test_ssl.pypython -m py_compile httpcore/_ssl.py httpcore/_backends/sync.py httpcore/_backends/anyio.py httpcore/_backends/trio.py tests/test_ssl.pygit diff --checkChecklist