Skip to content

EMULSIF-546: Accessibility tweaks#179

Merged
mariannuar merged 3 commits into
mainfrom
EMULSIF-546--accessibility-tweaks
Apr 17, 2026
Merged

EMULSIF-546: Accessibility tweaks#179
mariannuar merged 3 commits into
mainfrom
EMULSIF-546--accessibility-tweaks

Conversation

@mariannuar

@mariannuar mariannuar commented Nov 28, 2025

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes/implements the following bugs

  • The "Expand All" and "Collapse All" buttons do not indicate their disabled state programmatically when all accordions are already expanded or collapsed.The same is indicated visually using a different color
  • The tab widget has the below issues:
    1. It is not programmatically implemented as a proper tab component. Tabs are announced as links by screen readers
    2. The arrow icon used to access remaining tabs is not keyboard-operable, making it inaccessible to keyboard and screen reader users

Tickets

https://app.clickup.com/t/36718269/EMULSIF-438
https://app.clickup.com/t/36718269/EMULSIF-439

How to review this pull request

  • Visit the following https://deploy-preview-179--emulsify-ui-kit.netlify.app/
  • Go to an Accordion and confirm the "Expand All" and "Collapse All" buttons programmatically indicate their disabled state using aria-disabled="true"
  • Now visit Tabs and confirm Tabs are correctly announced as "tabs" by screen readers along with selected state. Users should be able to operate the arrow icon using keyboard

@netlify

netlify Bot commented Nov 28, 2025

Copy link
Copy Markdown

Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit a0878a9
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/692a022b34fbf800087c8039
😎 Deploy Preview https://deploy-preview-179--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mariannuar mariannuar changed the title Accessibility tweaks EMULSIF-546: Accessibility tweaks Nov 28, 2025
@mariannuar mariannuar self-assigned this Nov 28, 2025
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Nov 28, 2025

@robherba robherba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mariannuar, LGTM :shipit:!!

@robherba robherba added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. and removed 👍 Ready for Review Work is ready for review. labels Jan 12, 2026
@mariannuar
mariannuar merged commit ef5cb77 into main Apr 17, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants