release: fix use none as the canonical non-platform label#260
Merged
Conversation
fix: use none as the canonical non-platform label
fix: open develop version bump PR
chore(release): bump version to 4.0.1
chore(release): set version to 4.0.3
fix: rename no-platform release fixture
Contributor
|
🎉 This PR is included in version 4.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
genericwithnoneas the canonical platform identifier for projects without platform-specific behavior.none.genericconfiguration and environment overrides tonone.genericas a backward-compatible alias for existing projects.noneStorybookAdapterwhile preserving the existinggenericStorybookAdapterexport as an alias.none.Related Issue(s)
Notes:
"platform": "generic"will continue to work and will resolve internally tonone."platform": "none".dist.noneadapter behavior while retaining their configured platform name.Functional Testing:
npm run lint.npm run test.npm run fixtures:release."platform": "none"uses normaldistoutput and does not enable Drupal behavior."platform": "generic"resolves to the samenonebehavior.none.EMULSIFY_PLATFORM=genericoverride is normalized tonone.none, legacygeneric, and Drupal fixtures.Security
No new user-input handling or external execution paths are introduced. This change only normalizes platform identifiers and selects the existing non-Drupal adapter behavior.
Accessibility
No accessibility review is needed. This change does not alter rendered markup, styles, accessibility configuration, or interactive behavior.