Skip to content

chore#258

Merged
callinmullaney merged 12 commits into
mainfrom
develop
Jun 19, 2026
Merged

chore#258
callinmullaney merged 12 commits into
mainfrom
develop

Conversation

@callinmullaney

@callinmullaney callinmullaney commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

This PR does the following:

  • Promotes the latest develop changes to main.
  • Fixes Storybook production-build asset paths by:
    • Serving project assets and compiled dist/assets files from /assets.
    • Serving other compiled dist files from /dist.
    • Writing Storybook-generated chunks to .out/storybook-assets.
  • Resolves Storybook static directories from the consuming project root, whether @emulsify/core is linked locally or installed from node_modules.
  • Prevents Vite from clearing the Storybook output directory while static files are copied.
  • Updates the ESLint configuration to remove false-positive warnings for intentional filesystem, regular expression, and dynamic object-key usage.
  • Removes obsolete inline ESLint suppressions and performs related lint-only cleanup.
  • Adds axe-core as an explicit dependency of the shared Storybook preview configuration.
  • Adds regression tests and updates release fixtures for the new Storybook asset layout.

Related Issue(s)

  • N/A

Related PR(s)

Notes:

  • Existing project asset references under /assets remain unchanged.
  • Generated Storybook chunks move from .out/assets to .out/storybook-assets.
  • Files outside dist/assets are now available under /dist instead of at the Storybook output root.
  • The ESLint security plugin remains enabled. This change disables specific heuristics that produce false positives for intentional tooling patterns.
  • The lint cleanup does not change application features or runtime behavior.

Functional Testing:

  • Run npm run lint.
  • Run npm run test.
  • Run npm run fixtures:release.
  • Run npm run storybook-build in a consuming project.
  • Confirm generated Storybook chunks are written to .out/storybook-assets.
  • Confirm files from assets and dist/assets resolve under /assets.
  • Confirm other compiled files from dist resolve under /dist.
  • Confirm Storybook accessibility parameters continue to load correctly.

Security

No new user-input handling or external execution paths are introduced. The ESLint changes disable noisy static-analysis heuristics for intentional build-tooling patterns; the remaining recommended security rules stay enabled.

Accessibility

No rendered markup, styles, or interactive behavior are changed. Adding axe-core as a direct dependency formalizes the existing dependency used by the shared Storybook accessibility configuration.

dependabot Bot and others added 12 commits June 4, 2026 21:50
Bumps [lint-staged](https://github.com/lint-staged/lint-staged) from 17.0.5 to 17.0.7.
- [Release notes](https://github.com/lint-staged/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/main/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v17.0.5...v17.0.7)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-version: 17.0.7
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.1 to 4.2.0.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/commits)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.5.5 to 5.5.6.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v5.5.5...v5.5.6)

---
updated-dependencies:
- dependency-name: eslint-plugin-prettier
  dependency-version: 5.5.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@storybook/addon-themes](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/themes) from 10.4.1 to 10.4.2.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v10.4.2/code/addons/themes)

---
updated-dependencies:
- dependency-name: "@storybook/addon-themes"
  dependency-version: 10.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…aml-4.2.0

chore(deps): bump js-yaml from 4.1.1 to 4.2.0
…nt-plugin-prettier-5.5.6

chore(deps): bump eslint-plugin-prettier from 5.5.5 to 5.5.6
…-staged-17.0.7

chore(deps-dev): bump lint-staged from 17.0.5 to 17.0.7
…ybook/addon-themes-10.4.2

chore(deps): bump @storybook/addon-themes from 10.4.1 to 10.4.2
fix: create a proper asset reference path for storybook-build
chore: fix eslint warnings without changing features or functionality
@callinmullaney
callinmullaney merged commit ee6ada7 into main Jun 19, 2026
16 of 17 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant