[empath-split] End module names with : in manfests#25659
Merged
Conversation
This makes better distinction of module names and function lists. Suggested by by @sbc100 (emscripten-core#25577 (comment)). This has to land after WebAssembly/binaryen#8003.
sbc100
reviewed
Oct 27, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Presumably the tests need updating too?
Member
Author
|
Ping |
Member
Author
|
Ping ping |
sbc100
approved these changes
Nov 25, 2025
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Ooops, sorry I didn't realize i was the sole reviewer here.
| if line[-1] != ':': | ||
| exit_with_error(f"Module name should end with a colon: {line}") | ||
| if len(line) == 1: | ||
| exit_with_error("Module name is empty") |
Collaborator
There was a problem hiding this comment.
Use single quotes here and above.
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
…5659) This makes better distinction of module names and function lists. Suggested by by @sbc100 (emscripten-core#25577 (comment)). This has to land after WebAssembly/binaryen#8003.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes better distinction of module names and function lists. Suggested by by @sbc100 (#25577 (comment)).
This has to land after WebAssembly/binaryen#8003.