fix: mobile keyboard input in playground terminal#2
Merged
Conversation
Replace onKey with onData as the sole xterm.js input handler. onKey relies on KeyboardEvent which mobile virtual keyboards don't fire; onData receives terminal byte sequences from all input sources. Also default to emacs mode on mobile (no Escape key on virtual keyboards) and add tap-to-focus for opening the keyboard.
|
🔍 Preview deployed: https://28eb0de6.qualifier-dev.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onKeywithonDataas the sole xterm.js input handler —onKeyrelies onKeyboardEventwhich mobile virtual keyboards don't fire, causing every keystroke to be silently droppedNet -212 lines — the
onDataapproach matches terminal byte sequences inswitchstatements instead of jugglingdomEvent.code/domEvent.ctrlKey, which is both simpler and what xterm.js recommends.Test plan