Allows detection of end of end of input empty results#160
Open
arran4 wants to merge 3 commits intoemersion:masterfrom
Open
Allows detection of end of end of input empty results#160arran4 wants to merge 3 commits intoemersion:masterfrom
arran4 wants to merge 3 commits intoemersion:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there wasn't an obvious EOF passed through, or another form of special error. Header couldn't be made nil as it was publicly exposed and would constitute a signature change.
This does however introduce a behaviour change.
message.Readcan no return nil. Didn't seem to impact tests will probably impact users