This repository was archived by the owner on Aug 1, 2022. It is now read-only.
Fix issue where y coordinate isn't calculated correctly on iOS - #58
Open
CamilaAlvarez wants to merge 2 commits into
Open
CamilaAlvarez wants to merge 2 commits into
CamilaAlvarez wants to merge 2 commits into
Conversation
…s, when the canvas is placed on a modal
henrych4
reviewed
Jan 9, 2020
Owner
|
Thanks for the PR! Would it be possible for you to add a test for this case? |
Author
|
Sure! I’ll add one today.
El El mar, 28 de abr. de 2020 a la(s) 03:16, Martin Beierling-Mutz <
notifications@github.com> escribió:
… Thanks for the PR!
Would it be possible for you to add a test for this case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABN7GJO7HHTHB2EPF35M3QLROZ7FZANCNFSM4KE2UWVQ>
.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where y coordinate isn't calculated correctly on iOS devices, when the canvas is placed on a modal.