RFC#561 - {{lt}}, {{lte}}, {{gt}}, {{gte}} as keywords#21342
Merged
Conversation
4 tasks
Contributor
📊 Package size report 0.2%↑
🤖 This report was automatically generated by pkg-size-action |
Member
|
Same question here as #21339 (comment). |
bertdeblock
previously approved these changes
Apr 28, 2026
Add comparison helpers and register them as built-in keywords so they no longer need to be imported in strict-mode (gjs/gts) templates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli
force-pushed
the
nvp/lt-lte-gt-gte-as-keyword
branch
from
ee9583d to
c7c70b2
Compare
bertdeblock
previously approved these changes
Apr 30, 2026
kategengler
reviewed
May 1, 2026
Member
kategengler
left a comment
kategengler
left a comment
There was a problem hiding this comment.
I'm 👍 but we need to advance emberjs/rfcs#1179 to Ready for Release before landing.
driesdl
approved these changes
May 2, 2026
ef4
reviewed
May 4, 2026
| * | ||
| * left < right | ||
| */ | ||
| export function lt(left: unknown, right: unknown) { |
Contributor
There was a problem hiding this comment.
lt<T>(left: T, right: T): boolean;
This would be consistent with how typescript itself treats the native < operator.
Contributor
📊 Size reportTarball size — dist/dev 0.2%↑
dist/prod 0.2%↑
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
ef4
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #21309
Add comparison helpers and register them as built-in keywords so they no longer need to be imported in strict-mode (gjs/gts) templates.