Introduced template tags - #1218
Merged
Merged
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ijlee2
commented
Sep 2, 2026
| "ember-source": "~6.8.0", | ||
| "ember-styleguide": "^11.3.0", | ||
| "ember-styleguide": "^11.5.0", | ||
| "ember-template-imports": "^4.4.0", |
Member
Author
There was a problem hiding this comment.
ember-template-imports is required because the app doesn't run on @embroider/core@4.x and Vite.
ijlee2
commented
Sep 2, 2026
| "normalize.css": "^8.0.1", | ||
| "prember": "^2.1.0", | ||
| "prettier": "^3.9.6", | ||
| "prettier-plugin-ember-hbs-tag": "^2.0.3", |
Member
Author
There was a problem hiding this comment.
No longer needed because there are no test files that use the hbs tag.
ijlee2
commented
Sep 2, 2026
Comment on lines
+1
to
+3
| <meta property="st:title" content={{this.model.pageTitle}} /> | ||
| <meta property="og:title" content={{this.model.pageTitle}} /> | ||
| <meta name="twitter:title" content={{this.model.pageTitle}} /> No newline at end of file |
Member
Author
There was a problem hiding this comment.
@controller.model (what had been written before) caused assert.hasPageTitle()'s to fail, because the content attribute is missing a value. Replacing the syntax with this.model allowed the assertions to pass again.
jaredgalanis
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Ran ember-codemod-add-template-tags to remove all
*.hbsfiles andhbstags except forapp/templates/head.hbs, which seems to be required byember-cli-head.