Repository navigation
Test the non-Cypher branches on every engine - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: #70 moved two engine checks from
== ORACLEto!speaksCypher, and no test drives either one.Before
findChunksForEntity's non-Cypher branch: no test on any engine.DrivineNamedEntityDataRepository's constructor guard: no test.Now
AbstractRagSearchCharacterizationTestgainsfindChunksForEntity returns the chunks related to the entity, so the Cypher and non-Cypher branches run on all five engines. It fails on Postgres with the old== ORACLEcheck.DrivineNamedEntityDataRepositoryEngineTest: refused on ORACLE and POSTGRES with a message naming the engine andGraphObjectManagerEntityRepository; built on NEO4J, FALKORDB and MEMGRAPH.Test-only change.