Tests: launch fake helpers through a stable script - #97
Merged
Conversation
Parallel process starts can inherit a newly written executable handle and make Linux refuse exec with Text file busy. Keep the executable launcher build-owned and write each fake helper body as data instead. Preserve operating-system startup errors in plugin installation diagnostics rather than returning an unspecified failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the post-merge CI failure from #96, run https://github.com/emaspa/openxlr/actions/runs/34709759964.
The actual startup error was Linux
ETXTBSY, Text file busy. While a test writes an executable script, another thread can fork and temporarily inherit its writable handle. Exec then refuses the script even after the writing thread closed its own handle.Verification
No production retry policy, audio behavior, version or release changes.