Plugins: defer VST3 editor creation until requested - #92
Merged
Merged
Conversation
Creating and releasing an editor while loading triggers a pure virtual call in Elgato EQ when it is activated. Defer view creation until the editor is opened and keep the no-editor reply accurate. Cover the deferred no-editor result and add a real-plugin lifecycle diagnostic for processing, editor and activation checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Elgato EQ 1.3.0.110 crashes when activation follows a VST3 editor view being created and released. OpenXLR did that while loading to check for editor availability.
Verification
The plugin still fails if explicitly deactivated and reactivated after a view has been created. OpenXLR activates once per helper process, so its normal lifecycle does not take that path. The diagnostic documents it.
No version bump or release changes. Individual-plugin management is a separate change.