Refactor entry rendering after eww and optionally to retrieve content#577
Open
Thaodan wants to merge 3 commits intoemacs-elfeed:mainfrom
Open
Refactor entry rendering after eww and optionally to retrieve content#577Thaodan wants to merge 3 commits intoemacs-elfeed:mainfrom
Thaodan wants to merge 3 commits intoemacs-elfeed:mainfrom
Conversation
Also fix some minor errors reported by checkdoc.
Refactor entry rendering after eww. Now there's a separate render function that can specifically handle each content type. The render function is used as callback for eww if the retrieve of content through the entry link is enabled. If this is not used the render function is called directly with the content string. The retrieval of content option allows for several conditions to enable it such as always, regular expression match against the article link or length of content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor entry rendering after eww. Now there's a separate render
function that can specifically handle each content type.
The render function is used as callback for eww if the retrieve
of content through the entry link is enabled.
If this is not used the render function is called directly with the
content string.
The retrieval of content option allows for several conditions to
enable it such as always, regular expression match against the article
link or length of content.
Feedback welcome, it works for me but might require more polishing.