Fix error in example code for Best Practice page#815
Fix error in example code for Best Practice page#815KhamzaKhakim wants to merge 1 commit intoelysiajs:mainfrom
Conversation
WalkthroughDocumentation file updated to revise type access patterns from dot notation to bracket notation for AuthModel properties and add an export modifier to the AuthModel constant declaration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
Due to the previous removal of namespaces from the example folder structure, new errors arose in the service and controller files, which have been fixed.
https://elysiajs.com/essential/best-practice.html#folder-structure
Not sure if accessing types like
AuthModel["signInBody"]is the preferred approach though — happy to hear any thoughts.