Enhance service monitor with detailed failure logs#2
Merged
elkoled merged 1 commit intoOct 28, 2025
Merged
Conversation
elkoled
pushed a commit
that referenced
this pull request
Dec 15, 2025
* formatting * more * create directory if does not exist * mypy my bt * policy param catch exceptions * handle all params with exceptions * more * single method * define types in init * rename * simpler op enabled check * more mypy stuff * rename * no need for brake pressed * don't reset if gas pressed * type hint all * type hint all * back to upstream * in another pr * no longer need data type * qlog * slc in another pr * use horizontal accuracy * use horizontal accuracy * set core affinity for all realtime processes * unused * sort * unused * type hint and slight cleanup * from old implementation * use directly * combine pm * slight more cleanup * type hints * even more type hint * Revert "slc in another pr" This reverts commit 3a6987e * Revert "in another pr" This reverts commit a29bccf. * rebump * no need to check alive * use it directly * fix test * refactor * use gps data directly * quote...? * lint * fix tests * use CC.longActive * user confirm in another PR * rename * fix import * params fix * no more * fix * drop new state machine for now * more fixes * internalize output * unused * rearrange * auto draft * rename * this * no * no need * use existing * wrong cruise speed * fix * not used for now * Revert "not used for now" This reverts commit f0083d6. * some * use frames instead * split speed limit resolver out of slc * no need to pass sm * fix params * test init * use frame instead of time * track session * some tests * too limiting * bump * always reset state * end session if long_active but slc inactive at any given time * off * no warning in this PR * no speed factor engage type yet * wide open * no * introduce disabled, no longer transitions at inactive * fix tests * no more tempinactive * clean * rename * offset default > off * new tests, fixes controller * more tests * not really needed yet * lint * fix * some more tests * wrap * more * more * use vCruiseCluster for set speed * init better * finish it up * no * typo * one method state machine * refactor preactive timeout check * refactor new session check * directly return statuses * comments * v_target * refactor speed limit resolver * turn off debug * more resolver refactor * no longer needed * lint * more lint * fix * move around * fix events * update event * already happens while in enabled * add carstateSP * less * Speed Limit Control -> Speed Limit Assist * in another PR * more rename * overriding state * fix * make sure to return the correct type * sync with latest * housekeeping * use v cruise cluster instead * fix var * show it in UI! * actually show it * update event texts * todo * no override for now * wrong timer! * add vtarget and atarget * fix * handle no speed limit events * fix size * unused * skip preActive if init max speed was already reached * display last known speed limit and its state with SLA * pending event * much shorter disable guard * update events * convert max init for metric * fix even if unused atm * just use it * red for all * not disabled * rename * 10s pre active * kumar wants it higher, blame him * fix * pcm long only * some fixes * rename * use consolidate method to evaluate set speed status * init non pcm cruise * tests * disable non pcm long state machine for now * lint * lint * let the non PCM party begins * fix event * update event * use speed limit final last * only do direction checks if preActive * use resolver * use it directly * no longer applies * do it globally * non pcm long: adapting or pending unused * use button events instead of raw vals * need to initialize * move * what? * what #2??? * cst! * circular * slight fixes for tests * change up checks for user confirm * get buttonEvents at 100 hz and process for 20 hz consumption * get v cruise cluster from outer loop * Revert "get v cruise cluster from outer loop" This reverts commit be8068e. * Revert "get buttonEvents at 100 hz and process for 20 hz consumption" This reverts commit a739d4d. * don't need * do not allow target speed confirm if inactive * do not allow preActive if no valid speed limit * gimme them arrow pls * less * descriptive direction * fix event * update cs in 100 hz * Revert "don't need" This reverts commit 1eec763. * missed * wrong * stop * throw them to helpers class * property * hold speed behavior changes * abstract it * use converted to check last set speed change * Revert "do not allow target speed confirm if inactive" This reverts commit 9840e74 * pre active too short * slight fixes * fix tests * linty lint * speed limit changed hold timer for non pcm long * should be 0 * less loopy * some gates * special sauce for sla --------- Co-authored-by: nayan <nayan8teen@gmail.com> Co-authored-by: DevTekVE <devtekve@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6900e143552883228199731c94f32b1b