Skip to content

add a changelog#9

Open
petermueller wants to merge 7 commits into
mainfrom
pkm/changelog
Open

add a changelog#9
petermueller wants to merge 7 commits into
mainfrom
pkm/changelog

Conversation

@petermueller

Copy link
Copy Markdown
Collaborator

@petermueller

Copy link
Copy Markdown
Collaborator Author

@ulissesalmeida I was thinking we'd merge #6, then I'd update this as 0.2.1, then we can do that as a patch, then do the others as part of a 0.3.0

does that sound okay to you?

@ulissesalmeida

Copy link
Copy Markdown
Collaborator

I think the jose update and elixir v1.12 should be included in the 0.3.
The filename bug should be merged first and released as 0.2.1.

(I wouldn't mind everything being released as 0.3, so I'm with you whatever the path you choose)

@ulissesalmeida ulissesalmeida left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! 👏🏽

Comment thread CHANGELOG.md Outdated

### Removed

- **Breaking:** drop maintenance support for Elixir versions `< v1.12`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this has happened, should the mix.exs be updated to reflect the changed version requirement?

@petermueller petermueller Mar 27, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually why I haven't merged this. I think I originally added this thinking it would go with the jose update, but I may just remove this?

I need to run it to confirm 1.9 would still work though.

@petermueller

petermueller commented Apr 1, 2024

Copy link
Copy Markdown
Collaborator Author

Hmm, the ubuntu-20 runner isn't even picking these up, and I can't get 1.9.4-otp-22 to run locally (I think it's likely that I need to reinstall openssl-1.1-compat)

@ulissesalmeida or @fastjames, could one of you by chance try and compile and run the tests against 1.9 for this branch, or main?

@petermueller

Copy link
Copy Markdown
Collaborator Author

I was able to confirm it passes on 1.9, but you have to remove ex_doc, or roll it back to 0.22

It's been at 0.25 for nearly 2 years, which requires 1.10 anyway.

What do you think as far as support? I tend to fall in the camp of "follow what is considered supported by the core team", which goes back to 1.12

https://hexdocs.pm/elixir/1.16.2/compatibility-and-deprecations.html

@fastjames

Copy link
Copy Markdown
Contributor

I was able to confirm it passes on 1.9, but you have to remove ex_doc, or roll it back to 0.22

It's been at 0.25 for nearly 2 years, which requires 1.10 anyway.

What do you think as far as support? I tend to fall in the camp of "follow what is considered supported by the core team", which goes back to 1.12

https://hexdocs.pm/elixir/1.16.2/compatibility-and-deprecations.html

I am of the same opinion -- I think specifying 1.12 and up is the way to go.

@petermueller

Copy link
Copy Markdown
Collaborator Author

Ok. Between the 1.12, the deprecation of the fullname function (which is a minimal, thin wrapper, but it's still a deprecation) and the length of time, I don't think it makes sense to do a 0.2.1.

I'll take a look this week at merging the rest of the stuff, updating the changelog and mix.exs, and then release a 0.3.0 instead

Comment thread UPGRADING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make a CHANGELOG.md

3 participants