Skip to content

Avoid swallowing UndefinedFunctionError from GCS callbacks#41

Draft
vku2018 wants to merge 1 commit into
elixir-waffle:mainfrom
vku2018:codex/propagate-gcs-callback-errors
Draft

Avoid swallowing UndefinedFunctionError from GCS callbacks#41
vku2018 wants to merge 1 commit into
elixir-waffle:mainfrom
vku2018:codex/propagate-gcs-callback-errors

Conversation

@vku2018

@vku2018 vku2018 commented Jul 3, 2026

Copy link
Copy Markdown

Summary

  • detect optional GCS callbacks with Code.ensure_loaded? and function_exported?/3 instead of rescuing UndefinedFunctionError
  • call exported callbacks directly so real undefined function failures inside gcs_object_headers/2 or gcs_optional_params/2 propagate
  • add regression tests for callback bodies that raise UndefinedFunctionError

Fixes #30

Validation

  • git diff --check
  • Unable to run mix format --check-formatted or mix test because elixir/mix are not installed in this environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UndefinedFunctionError raised inside gcs_object_headers/gcs_optional_params is silently swallowed

2 participants