Repository navigation
Fix dynamic RoPE scaling formula - #476
Merged
Merged
Conversation
Assisted-By: Claude Opus 5.5
Member
|
Good catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dynamic RoPE scaling,
basewas inadvertently raised to the power ofdim / (dim - 2)along with the context scaling multiplier due to pipeline operator ordering.According to NTK-aware dynamic scaling:
Previously,
(base * scale)was raised to the exponent. This PR fixes the calculation so only the scaling factor is exponentiated before multiplying withbase:References
• Matching implementation in Hugging Face modeling_rope_utils.py https://github.com/huggingface/transformers/blob/main/src/transformers/modeling_rope_utils.py (_compute_dynamic_ntk_parameters)
• Mathematical derivation: NTK-aware Scaling Context Extension https://mbrenndoerfer.com/writing/ntk-aware-scaling-context-extension
• Original proposal: Reddit /r/LocalLLaMA discussion https://www.reddit.com/r/LocalLLaMA/comments/14mrgpr/dynamically_scaled_rope_further_increases/
This PR fixes the calculation and adds a unit test in
LayersTest.codex and antigravity was used to find and fix it.