Add :wrap_in_transaction option to explain#682
Merged
greg-rychlewski merged 4 commits intoJul 21, 2025
Conversation
josevalim
approved these changes
Jul 21, 2025
josevalim
left a comment
Member
There was a problem hiding this comment.
Code wise looks good to me. I wonder if we should call it :transaction or :wrap_in_transaction though, although I am happy to go with what you decide!
Member
Author
|
I like |
josevalim
approved these changes
Jul 21, 2025
:rollback option to explain:wrap_in_transaction option to explain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes elixir-ecto/ecto#4641
There were two options discussed:
analyze: falseI went for the first option for two reasons:
analyze: true