Add support for ON DELETE SET DEFAULT#677
Merged
Merged
Conversation
Member
|
@makmn1 Thanks very much for the PR. Would you be able to add default_all unit tests for TDS? |
6609d5d to
d1a399c
Compare
Contributor
Author
|
Good catch, I added those missing tests and also updated the PG unit test for testing default_all with a composite key |
Member
|
I didn't know this feature existed in postgres. I don't think it exists in sqlite. If this is added, I'll need to update the adapter to raise an error that is easy to understand. |
josevalim
approved these changes
Jun 24, 2025
Contributor
Author
|
@warmwaffles It looks like it does exist in SQLite, but you can't choose columns (so similar to how MSSQL supports) |
greg-rychlewski
approved these changes
Jun 24, 2025
Member
|
Thanks for adding this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to a discussion and pull requests #474 and #475
This pull request adds support for the SET DEFAULT action for ON DELETE on a foreign key constraint. It's similar to the current
:nilify_alland{:nilify, columns}options, but for setting the column values to their default values. Additionally, database support is different between each of the three supported databases:Sources for SET DEFAULT behavior