Repository navigation
Bring the warm Slack session up on Claude Code 2.1.303 and cmux 0.65 - #47
Merged
Merged
Conversation
…ce-close its own failed workspace Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d ban the canonical cmux close Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the Slack daemon restarted, every warm session spawn failed with "boot prompt never submitted", and each failure left a cmux workspace open.
transcript_has_submissionread only the last 256 KB, so it never saw the boot prompt, though the session had run it ("Prompt loaded. Standing by."). It now reads and searches the whole file, which takes about 22 ms on the largest transcript here (108 MB). A line that isn't valid UTF-8 is skipped, not fatal.confirmation_requiredwhen it's asked to close a workspace with a running process.close_own_workspacenow retries with--forceonly on that error. The title check is unchanged, so it still closes only its ownassistant-comms (warm)workspace. The close ban test now also catches the canonicalcmux workspace closeform.Validation
main(whole-file search, forced close) and pass here. 217 tests in the comms test files pass.find_submissionon the real project folder finds it in 15 ms.cmux close-workspace --workspace <ref> --forceclosed one leaked warm workspace (OK workspace:1000010024).🤖 Generated with Claude Code