cmake/docs: fix macOS install RPATH and update install notes#105
Open
JulianGrg wants to merge 2 commits into
Open
cmake/docs: fix macOS install RPATH and update install notes#105JulianGrg wants to merge 2 commits into
JulianGrg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves macOS installation support in two ways.
First, it updates the CMake install configuration so that the installed
dwexecutable receives a macOS runtime library search path. Without this,dwcan fail after installation with:The CMake change adds an Apple-specific
INSTALL_RPATHpointing from the installed executable directory to the installed library directory:@loader_path/../${CMAKE_INSTALL_LIBDIR}This should allow the installed
dwbinary to findlibkdtree.dylibwithout requiring users to patch the binary manually withinstall_name_tool.Second, this PR updates the macOS installation documentation with:
libompomp.his not foundlibkdtree.dylibruntime-path issueThe documentation keeps the manual
install_name_toolworkaround as a troubleshooting fallback, but the CMake change should avoid the need for it in normal installations.I kept the old macOS install notes, but they can be removed if wished.