Improve: Jquery gets elements by Id.#73
Open
denniscastro wants to merge 1 commit into
Open
Conversation
Before: just get first elemment Now: gets all the elements with same Id
|
Its probably a bad idea overall to have duplicate HTML id attributes on the page anyway. Since this lib does so when multi-day events "wrap", it'd probably be a good idea to revert back to the "class style" event identification (i.e. For that matter, couldn't you even match the CSS class |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: just get first elemment
Now: gets all the elements with same Id