Repository navigation
SystemUpdate: Handle offline notifications after registration - #250
Closed
Sean-StarLabs wants to merge 1 commit into
Closed
Sean-StarLabs wants to merge 1 commit into
Sean-StarLabs wants to merge 1 commit into
Conversation
The constructor runs during D-Bus registration. Handle the previous update result at startup, when notifications can use the application connection. Test=StarFighter: traced notification withdrawal after registration; no startup assertion. Fixes: f2e743b ("SystemUpdate: withdraw old notifications on startup (elementary#119)") Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Member
|
Hey Sean, Just asking again if you can confirm that you're not using LLMs in this branch or the other branches you've submitted, as per our contributor guidelines here: https://docs.elementary.io/contributor-guide/development/generative-ai-policy |
Author
|
Using in any shape or form? 100% |
Member
|
@Sean-StarLabs sorry does that mean 100% you are or 100% you are not? |
Author
|
I am |
Member
|
@Sean-StarLabs sorry we don't accept contributions created with LLMs. Please see the contributor guide section I linked |
Author
|
I never said it was created by one :) |
Member
|
@Sean-StarLabs In the future please be aware of our generative AI policy and do not use LLMs when contributing to our project. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor runs during D-Bus registration. Handle the previous update result at startup, when notifications can use the application connection.
Test=StarFighter: traced notification withdrawal after registration; no startup assertion.
Fixes: f2e743b ("SystemUpdate: withdraw old notifications on startup (#119)")