Fix meson warning for run_command#1139
Open
turbobastii wants to merge 4 commits into
Open
Conversation
eli-schwartz
reviewed
Oct 2, 2022
eli-schwartz
left a comment
eli-schwartz
left a comment
There was a problem hiding this comment.
This fixes the warning while keeping the current default.
Please don't keep the current default, the entire reason for the warning is because the current default is usually bad, and in this particular case, it goes to show why that was bad.
eli-schwartz
reviewed
Oct 2, 2022
turbobastii
force-pushed
the
fix/meson-run-command
branch
from
October 3, 2022 05:36
9d0ea05 to
7458808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running meson build, there is a warning about run_command changing its defaults in the future.
(See: mesonbuild/meson#9300)
The same issue was addressed in this PR: elementary/code#1207
This fixes the warning while keeping the current default.UPDATE: after the feedback, I changed the check totrue.