improve nested attributed types & add more html tuples#98
Merged
sliemeobn merged 7 commits intoelementary-swift:mainfrom Mar 26, 2026
Merged
improve nested attributed types & add more html tuples#98sliemeobn merged 7 commits intoelementary-swift:mainfrom
sliemeobn merged 7 commits intoelementary-swift:mainfrom
Conversation
Use the same array of the original attributes instead of wrapping the html content on every attributes function call.
Collaborator
|
thanks for this! I wonder if we could extend the attribute handling to also work for wdyt? |
Contributor
Author
Is the current implementation not working for Edit: nevermind, I get what you mean. Will work on it right now. |
Collaborator
|
nice! I ran the benchmarks, looking good! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requests adds more tuples for OS that do not support parameter packs (embedded). I have also improved nested _AttributedElement, which should improve typed compilations.
If there are any questions feel free to let me know.