enable proxying requests to a book sync service - #2
Open
jduar wants to merge 1 commit into
Open
Conversation
Owner
|
pretty sweet. i didn't think about doing that inside of readeckobo itself! i've been handling this at the reverse proxy layer instead. i'll give this PR a study to better understand the implementation and tradeoffs. i am interested. thank you! |
Author
|
Looking at your snippet, it does look like a simpler solution actually - I wish I'd thought of it before 😅 Right now I'm undecided which is the best approach under my "in one year when I completely forget how I set these up will I understand what's happening?" rule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables proxying requests to a book sync service like Grimmory, basically allowing me to run both Readeckobo for Readeck articles through Instapaper and Grimmory with which I sync books and reading progress.
I found readeckobo a few days ago and was going to set it up only to realize it used the same
api_endpointGrimmory and other book services already use. It would probably be a lot of work adding article functionality to those, so I thought of modifying Readeckobo to proxy requests it doesn't handle to Grimmory instad of the Kobo store. So I tested my theory and it works! With this I can have both article and book sync from two different services.I tried to keep the changes as minimal as possible while keeping the mechanism generic so it supports the many book services like Grimmory, Komga, Calibre Web, etc. My understanding is that these all sync books pretty much the same way with slightly different endpoints.
I've only actually tested this against Grimmory though and have it running fine in my Kobo. I also tried making the configuration steps as clear as possible but feel free to suggest any changes.