Skip to content

ci: bump secret-service-action to v1.1.0 - #221

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. This step gets the GitHub token that the release job publishes with, so a human should still confirm that the new pin is the real v1.1.0 release of electron/secret-service-action. I couldn't check the upstream repo from here.

What was reviewed:

  • The one-line pin change in .github/workflows/release.yml: the action is still pinned to a full SHA, and the version comment matches the PR title.
  • The step that uses it: semantic-trusted-release reads fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN. That only keeps working if v1.1.0 still returns a secrets JSON output, and I couldn't confirm that here.
  • Job permissions (id-token: write, the npm-trusted-publisher environment) are unchanged.
Extended reasoning...

The change bumps the pinned SHA of electron/secret-service-action in the release workflow from v1.0.0 to v1.1.0. That action supplies the GitHub token used by the release job, which runs with id-token: write in the npm-trusted-publisher environment, so this is supply-chain and credential-sensitive. I couldn't confirm in this session that the new SHA is the v1.1.0 tag, or that the action's outputs are unchanged. The CODEOWNERS wildcard assigns every path, including this workflow, to the ecosystem working group. For these reasons I deferred instead of approving.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:41
@MarshallOfSound
MarshallOfSound merged commit 29019ce into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:54
@electron-npm-package-publisher

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants