Skip to content

ci: move Node 20 jobs to a supported Node line - #219

Merged
MarshallOfSound merged 1 commit into
mainfrom
ci/drop-node-20
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
ci/drop-node-20

Conversation

@claude

@claude claude Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

The release job in release.yml moves off end-of-life Node 20 to Node 22.x, matching .nvmrc, the test matrix and engines (>=22.12.0); semantic-trusted-release still brings its own Node 24 for npm publishing. The floating setup-node step now sets check-latest: true.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MM6DBDZdmumVSaiGNt2vF7
@claude
claude Bot requested a review from a team as a code owner October 21, 2026 23:43

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and found no new bugs. It's a small change, but it touches the release workflow and the CODEOWNERS file assigns this path to the ecosystem working group, so a maintainer should still look at it.

What was reviewed:

  • The Setup Node.js step in .github/workflows/release.yml: node-version goes from 20.x to 22.x and check-latest: true is added. The action is still pinned to the same commit SHA.
  • I checked that the new version matches the repo's other Node declarations. .nvmrc is 22.23.4 and engines is >=22.12.0, so a 22.x release runner satisfies both.
Extended reasoning...

The only change is one setup-node step in .github/workflows/release.yml. It moves the release job from Node 20.x to 22.x and adds check-latest: true, and the action stays pinned to the same SHA. No source, test or other config files change. The release workflow publishes to npm, which makes it the release path rather than an auth or crypto change. CODEOWNERS assigns all paths to a maintainer team, which is why a human review is suggested instead of approving.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 00:01
@MarshallOfSound
MarshallOfSound merged commit 5a55488 into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/drop-node-20 branch October 22, 2026 00:17
@electron-npm-package-publisher

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants