Skip to content

build(deps-dev): upgrade vitest to v5 - #207

Merged
dsanders11 merged 1 commit into
mainfrom
vitest-5
Sep 23, 2026
Merged

dsanders11 merged 1 commit into
mainfrom
vitest-5

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by David Sanders · Slack thread

This upgrades vitest from v4 to 5.0.1 and bumps @vitest/coverage-v8 from the stale exact pin of 3.0.5 to 5.0.1, since the coverage package peer-pins vitest exactly. Vitest 5 makes vite a required peer instead of a dependency, so vite is now listed as a devDependency (^8.0.16, the version previously in the lockfile). No test or config changes were needed; lint, build, and all 235 tests pass locally, and coverage runs cleanly. The release workflow's Node 20.x setup was left alone because that job only installs, builds, and publishes; the tests it depends on run through test.yml on Node 22.12.x.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N2vvE5XzurMvQfsX7Vz7bF
@claude
claude Bot requested a review from a team as a code owner September 23, 2026 21:23
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​vitest/​coverage-v8@​3.0.5 ⏵ 5.0.19910079 +798100
Updatedvitest@​4.1.11 ⏵ 5.0.198 +110079 +198100
Addedvite@​8.3.0991008296100

View full report

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward dev-dependency version bump.

  • Checked package.json: @ vitest/coverage-v8 and vitest are both pinned/ranged to align on 5.0.1, and the new explicit vite devDependency matches the version already resolved in the old lockfile.
  • Checked yarn.lock: resolved versions (vitest@ 5.0.1, @ vitest/coverage-v8@ 5.0.1, vite@ 8.3.0) are consistent with the package.json ranges, and the large deletion count is explained by the dependency graph shrinking under vite/vitest v5+v8.
  • Considered whether the exact coverage-v8 pin vs. caret vitest range could drift out of lockstep in the future, and whether the repo's 7-day npm age gate could block this exact install — both are pre-existing/config-level risks unrelated to correctness of this change, not introduced bugs.
Extended reasoning...

This is a dev-only dependency bump (vitest v4→v5, coverage-v8 v3→v5, new explicit vite v8 devDependency) plus a mechanically regenerated yarn.lock; no application/runtime code changed, so there is no security-sensitive surface. package.json and yarn.lock are mutually consistent, the PR description's claims match the diff, no CODEOWNERS restriction applies, and the bug hunter's dry_streak exit plus two ruled-out theoretical lockstep/age-gate concerns support a low-risk mechanical change.

@dsanders11
dsanders11 merged commit 3f706bc into main Sep 23, 2026
10 checks passed
@dsanders11
dsanders11 deleted the vitest-5 branch September 23, 2026 21:47
@electron-npm-package-publisher

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants