Skip to content

chore: use object form for package.json bin - #498

Merged
MarshallOfSound merged 2 commits into
mainfrom
chore/object-form-bin
Nov 14, 2026
Merged

MarshallOfSound merged 2 commits into
mainfrom
chore/object-form-bin

Conversation

@claude

@claude claude Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Requested by Erick Zhao · Slack thread

npm 11 logs "bin[asar]" script name bin/asar.mjs was invalid and removed on every publish because of a logging bug in @npmcli/package-json's bin normalization (https://github.com/npm/package-json/blob/main/lib/normalize.js#L65-L71) that fires for string-form or ./-prefixed bins; nothing is actually removed. This switches bin to the object form npm pkg fix writes ({"asar": "bin/asar.mjs"}), which silences the warning; the published bin is unchanged (verified with npm publish --dry-run on npm 11.19.1, and it matches the registry manifest for 4.3.2).


Generated by Claude Code

Silences npm's misleading "script name ... was invalid and removed" publish warning; the published bin is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PiGRtA44mDWPhGNex1cSia
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PiGRtA44mDWPhGNex1cSia
@erickzhao
erickzhao marked this pull request as ready for review November 12, 2026 19:03
@erickzhao
erickzhao requested a review from a team as a code owner November 12, 2026 19:03

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@MarshallOfSound
MarshallOfSound merged commit 4587f64 into main Nov 14, 2026
10 checks passed
@MarshallOfSound
MarshallOfSound deleted the chore/object-form-bin branch November 14, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants