fix: avoid loading caller cwd dotenv in server#23
Open
mane wants to merge 1 commit into
Open
Conversation
Contributor
|
This is correct and complete for its goal — removing the top-level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotenv.config()call so it does not implicitly import.envfrom the caller's working directory.Bug verified
ConfigManageralready avoidsprocess.cwd()/.env, butsrc/server.tsimporteddotenvand calleddotenv.config()before the server initialized. When T3MP3ST is run from or inside an audited target repo, that re-enables cwd.envloading and can contaminate the server process with unrelated target secrets.RED before fix:
npx vitest run src/__tests__/api-key-env-static.test.tsfailed on the new invariant becausesrc/server.tsstill containedimport dotenv from 'dotenv'/dotenv.config().Test plan
npx vitest run src/__tests__/api-key-env-static.test.tsnpm testnpm run typechecknpm run lint(existing warnings only, 0 errors)npm run verify-claims