-
Notifications
You must be signed in to change notification settings - Fork 199
ECE: customize logging and metrics retention with ILM and data streams #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vale Linting ResultsSummary: 1 suggestion found 💡 Suggestions (1)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
kunisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did quick check and left some comments. Mainly about making sure the user expectation on sizing, and some tech details.
|
@kunisen : I've made changes based on your suggestions. Really great catches. |
kunisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great! Thanks Edu for your time effort on this! ❤️
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
deploy-manage/monitor/orchestrators/ece-monitoring-ece-set-retention.md
Outdated
Show resolved
Hide resolved
kilfoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ⛵
Looks great @eedugon!
If I'm not mistaken, this new page is basically an ECE-specific version of the general procedure described in Customize built-in ILM policies in Elasticsearch, so it might be helpful to mention that somewhere with a link.
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
|
Thanks for the review and improvements suggestions @davidkyle , all of them are more than welcome!
I didn't know it, thanks! I'll find the way to add it as a reference. I finally didn't include anything about component templates and |
Summary
Updating the document to set retention of logging and metrics data on ECE.
Improvements:
Closes https://github.com/elastic/docs-content-internal/issues/466
Closes https://github.com/elastic/cloud/issues/116800
Generative AI disclosure
Tool(s) and model(s) used: Cursor in auto mode