Skip to content

fix(page-card): apply UrlPathPrefix to resolved URLs #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theletterf merged 9 commits into from
Jun 11, 2026
+10 −5
Merged

fix(page-card): apply UrlPathPrefix to resolved URLs #3490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d8e36e
feat(cli-reference): support title overrides
theletterf Jun 10, 2026
b495530
Merge branch 'main' into cli-reference-title-overrides
theletterf Jun 10, 2026
629708a
Merge origin/main and resolve CLI markdown conflict
Copilot Jun 10, 2026
51b9694
Merge remote branch cli-reference-title-overrides
Copilot Jun 10, 2026
b598a20
fix(cli-reference): ignore blank title overrides
theletterf Jun 10, 2026
7566ded
fix(cli-reference): use segment path instead of segment/index.md for …
theletterf Jun 11, 2026
66ba93e
fix(cli-reference): trim title and navigation_title override values
theletterf Jun 11, 2026
c434430
Merge origin/main
theletterf Jun 11, 2026
1945fcf
fix(page-card): apply UrlPathPrefix to resolved URLs
theletterf Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Elastic.Markdown/Extensions/CliReference/CliMarkdownGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static string RootPage(CliSchema schema, CliSupplementalDoc? supplemental
_ = sb.AppendLine("## Namespaces");
_ = sb.AppendLine();
foreach (var ns in schema.Namespaces)
AppendPageCard(sb, ns.Segment, $"./{ns.Segment}/index.md", ns.Summary);
AppendPageCard(sb, ns.Segment, $"./{ns.Segment}", ns.Summary);
}

if (schema.Environment?.Variables is { Count: > 0 } envVars)
Expand Down Expand Up @@ -129,7 +129,7 @@ public static string NamespacePage(
{
var depth = fullPath?.Length ?? 1;
var upPrefix = string.Concat(Enumerable.Repeat("../", depth));
var links = nsAliases.Select(a => $"[`{binaryName ?? a} {a}`]({upPrefix}{a}/index.md)");
var links = nsAliases.Select(a => $"[`{binaryName ?? a} {a}`]({upPrefix}{a})");
_ = sb.AppendLine($"Also accessible as {string.Join(", ", links)}.");
_ = sb.AppendLine();
}
Expand Down Expand Up @@ -159,7 +159,7 @@ public static string NamespacePage(
_ = sb.AppendLine("## Sub-namespaces");
_ = sb.AppendLine();
foreach (var sub in subNamespaces)
AppendPageCard(sb, sub.Segment, $"./{sub.Segment}/index.md", sub.Summary);
AppendPageCard(sb, sub.Segment, $"./{sub.Segment}", sub.Summary);
}

var options = ns.Options ?? [];
Expand Down
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Extensions/CliReference/CliRootFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public CliRootFile(
{
_schema = schema;
_supplementalDoc = supplementalDoc;
_title = string.IsNullOrWhiteSpace(title) ? schema.Name : title;
_navigationTitle = string.IsNullOrWhiteSpace(navigationTitle) ? $"{schema.Name} CLI" : navigationTitle;
_title = string.IsNullOrWhiteSpace(title) ? schema.Name : title.Trim();
_navigationTitle = string.IsNullOrWhiteSpace(navigationTitle) ? $"{schema.Name} CLI" : navigationTitle.Trim();
Title = _title;
}

Expand Down
5 changes: 5 additions & 0 deletions src/Elastic.Markdown/Myst/Directives/PageCard/PageCardBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ public override void FinalizeAndValidate(ParserContext context)
: relativeToSource;

ResolvedUrl = "/" + withoutExtension.Replace('\\', '/');

// Apply URL path prefix so links work in preview/sub-path deployments (same logic as DiagnosticLinkInlineParser)
var urlPathPrefix = context.Build.UrlPathPrefix ?? string.Empty;
if (!string.IsNullOrWhiteSpace(urlPathPrefix) && !ResolvedUrl.StartsWith(urlPathPrefix, StringComparison.OrdinalIgnoreCase))
ResolvedUrl = $"{urlPathPrefix.TrimEnd('/')}{ResolvedUrl}";
}

[GeneratedRegex(@"^\[([^\]]+)\]\(([^)]+)\)$")]
Expand Down
Loading