Skip to content

flask: avoid warnings reading recent flask versions #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 1 commit into from
May 15, 2026
+6 −1
Merged

flask: avoid warnings reading recent flask versions #2635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion elasticapm/contrib/flask/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,11 @@ def init_app(self, app, **defaults) -> None:

if "framework_name" not in defaults:
defaults["framework_name"] = "flask"
defaults["framework_version"] = getattr(flask, "__version__", "<0.7")
try:
flask_version = __import__("importlib.metadata").metadata.version("flask")
except ImportError:
flask_version = getattr(flask, "__version__", "<0.7")
defaults["framework_version"] = flask_version

self.client = self.client_cls(config, **defaults)

Expand Down
1 change: 1 addition & 0 deletions tests/contrib/flask/flask_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ def test_framework_name(flask_app):
assert apm.client.config.framework_name == "flask"
app_info = apm.client.get_service_info()
assert app_info["framework"]["name"] == "flask"
assert app_info["framework"]["version"]
apm.client.close()

# Cleanup -- we don't use the flask_apm_client fixture here because it uses
Expand Down
Loading