Open
Conversation
|
💚 CLA has been signed |
🤖 GitHub commentsJust comment with:
|
28b2a95 to
faef8f7
Compare
🔍 Preview links for changed docs |
faef8f7 to
f81fe06
Compare
f81fe06 to
46cecc1
Compare
46cecc1 to
926a657
Compare
19 tasks
|
What is the status of this PR @Mistborn94 ? Many developers need these support. |
Contributor
Author
|
It is ready to review - I just need this project's mainainers to review and merge. |
Contributor
|
it's failing tests |
Contributor
Author
|
@jackshirazi These tests were also failing on master when I checked last week and is also failing on other open PRs with the dame error :( I'm not sure what I can do to fix it... |
|
These PR looks really good. You have added a lot of tests and fixed main problem with headers which we also noticed. Nice! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4345
What does this PR do?
Implements support for Spring Boot 4 / Spring Framework 7
Checklist
Added an API method or config option? Document in which version this will be introduced