Skip to content

fix(eloot.lic): v2.8.2 fix hoarding settings error#2306

Merged
mrhoribu merged 1 commit into
masterfrom
fix/eloot-v2.8.2
May 2, 2026
Merged

fix(eloot.lic): v2.8.2 fix hoarding settings error#2306
mrhoribu merged 1 commit into
masterfrom
fix/eloot-v2.8.2

Conversation

@mrhoribu
Copy link
Copy Markdown
Contributor

@mrhoribu mrhoribu commented May 2, 2026

Updated version to 2.8.2 and added a bugfix for hoarding settings.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed hoarding validation error that occurred when container settings were empty while overflow hoarding was enabled and overflow containers were available.
    • Version updated to 2.8.2.

Updated version to 2.8.2 and added a bugfix for hoarding settings.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79ec0db0-0bde-4608-8682-d592df67a124

📥 Commits

Reviewing files that changed from the base of the PR and between 5efccd2 and 9f9f188.

📒 Files selected for processing (1)
  • scripts/eloot.lic

📝 Walkthrough

Walkthrough

Version bumped to 2.8.2 with a hoarding validation bugfix. The validate_hoarding_settings method now correctly permits empty container_settings when overflow hoarding is enabled and overflow containers exist, rather than always erroring on empty settings.

Changes

Hoarding Validation Bugfix

Layer / File(s) Summary
Core Validation Logic
scripts/eloot.lic (lines 3855–3858)
Added has_overflow detection to determine whether overflow hoarding is usable. The validation now errors on empty container_settings only when overflow is unavailable.
Version & Changelog
scripts/eloot.lic (lines 18–23)
Bumped version to 2.8.2 and documented the bugfix entry in the changelog.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: a bugfix for hoarding settings validation with a version bump from 2.8.1 to 2.8.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/eloot-v2.8.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@mrhoribu mrhoribu merged commit 28a06c3 into master May 2, 2026
4 checks passed
@mrhoribu mrhoribu deleted the fix/eloot-v2.8.2 branch May 2, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant