Conversation
5b90213 to
6ed17e5
Compare
6ed17e5 to
1c7bbfa
Compare
|
@ekrich The tests are failing, but they also locally fail on my machine i.e.
|
|
I am not excited about this. The current Github action is so simple. We probably need to add Java 21 and see what is wrong with that. I like to stay on old distros - only move forward when Github removes them. This is partly for Scala Native. I think that OSes should be older than JVM support because the later is easier to upgrade. |
Just wanted to mention that all of this is easily configurable with sbt-github-actions. You can precisely specify what OS, what version, what java versions etc etc. Should I update the PR so that we aren't pinned to latest? |
|
I would prefer to just use the simple CI for now - it is very similar to my other projects and this one just seems to add complexity. I also want to minimize the matrix although Java 25 will be added once dependencies get updated perhaps with the next release. Does Pekko support Scala 2.12 or has that been dropped? I have held on since both Scala.js and Scala Native still support 2.12. |
It would be Pekko 2.x that would use sconfig and that version of Pekko has dropped Scala 2.12 so you don't need to worry about it. In fact if you are dropping Scala 2.12 it would be great if you drop ccompat (it's not needed anyways) as we want to keep dependencies to a minimum |
|
See #478 (comment) |

This PR implements the use of sbt-github-actions to automatically device github actions CI for running tests from the sbt build. Using sbt-github-actions reduces the maintenance as it automatically handles
The currently generated matrix is quite large (its basically testing every JDK from 8 to 21 on every OS) so I can reduce it down if requested.
sbt-github-actions can also be easily set up to handle publishing by tag pushing using sbt-ci-release. I haven't done this in this PR, but it can easily be added in the future (see https://github.com/sbt/sbt-license-report/blob/fa26f24b031f9b4ba46e52ac8ee365f9c3aad25f/build.sbt#L91-L108 as an example of what it looks like)