fix(llm): points-centred leading/following facts (no recommendations)#430
Merged
Conversation
…ndations Follow-up to #429, from live gemini-2.5-flash-lite games. Re-centres every lead/follow fact on POINT yield/risk + resource cost (not trick-winning), keeps it all facts/diagnosis (the LLM still decides), and fixes several mis-framings. Following: - Concessions anchored to the 80 threshold, role-aware, so "defending" can't be read as "feed the attackers" (a defender now sees "adds N pts to the attackers' total"; an attacker "gives the defenders N pts — lost from your 80"). - A future-boss card (e.g. your Ace under a led Ace) is listed apart from the trash instead of collapsed into it, so it isn't dumped. - 3rd-seat overtake split: overtaking a SAFE teammate = "no gain"; an UNSAFE one = "shield the N pts from {opp}" — a cost fact, not auto-help. - A 5 is treated as a point card in disposal (split from higher non-points). Leading: - Beatable point-card leads (K/10) flagged as FEEDING points; non-point J/Q as tempo-only. - Trump high single (BJ) = wins but ≈no points + burns your top trump; low single = cheap concede; strong pairs = drain framing gated by dominance context (pairs held / trump still out / pairs already led). - Off-suit "unbeatable" softened to "wins unless ruffed" (the flag is same-suit only); duplicate single-leads collapsed. Other: - Void list caveat: confirmed only by an off-suit discard, so absence ≠ proof. - Neutrality pass: removed all recommendation-creep; only legality laws and the task instruction remain directive. Tests extended to pin all of the above (736 total). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #429, driven by live
gemini-2.5-flash-litegames. Re-centres every leading/following fact on point yield/risk + resource cost (not trick-winning), and keeps it all facts/diagnosis — the LLM still decides.Following
Leading
Other
Verified with
npm run qualitycheck(736 tests, lint + typecheck clean) and rendered-prompt review.🤖 Generated with Claude Code