feat: allow user-supplied loader/plugin to handle *.module.css - #1404
Open
ishristov wants to merge 1 commit into
Open
feat: allow user-supplied loader/plugin to handle *.module.css#1404ishristov wants to merge 1 commit into
ishristov wants to merge 1 commit into
Conversation
The built-in postcss plugin registers onLoad({ filter: /\.css$/ }, ...), which greedily claims every .css file — including .module.css. This prevents users from wiring esbuild's native local-css loader (or any custom plugin) for CSS Modules via esbuildOptions.
With this change, we can bail early in the postcss onLoad handler when the file ends in .module.css, so downstream plugins/loaders can pick it up. No behavior change unless the user has explicitly configured a .module.css handler themselves.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Someone is attempting to deploy a commit to the EGOIST's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in postcss plugin registers
onLoad({ filter: /\.css$/ }, ...), which greedily claims every .css file - including .module.css. This prevents users from wiring esbuild's native local-css loader (or any custom plugin) for CSS Modules via esbuildOptions.With this change, we can bail early in the postcss onLoad handler when the file ends in
.module.css, so downstream plugins/loaders can pick it up. No behavior change unless the user has explicitly configured a.module.csshandler themselves.