fix: resolve browser field in DTS generation for platform: browser - #1399
Open
godfengliang wants to merge 2 commits into
Open
fix: resolve browser field in DTS generation for platform: browser#1399godfengliang wants to merge 2 commits into
godfengliang wants to merge 2 commits into
Conversation
When using --platform browser --dts, the DTS rollup resolver ignores the browser field in package.json, causing type definitions to resolve to the non-browser entry point. This adds a platform option to tsResolvePlugin and applies browser field mappings in packageFilter when platform is browser. Fixes egoist#1397
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@godfengliang is attempting to deploy a commit to the EGOIST's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using , the generated files resolve to the non-browser entry point because the DTS rollup resolver ignores the field in .
For example, a package with:
correctly bundles , but generates types from instead.
Fix
Fixes #1397