fix(adr-authoring): align decisions with ratified Hygiene policy - #100
Merged
Merged
Conversation
Pull Request Summary by devActivityMetricsAchievements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ADR skill previously excluded proposals while the managed decision-impact hook required them and still selected pre-ratification policy. This aligns the existing specification, skill, templates and generated guidance with ratified Hygiene ADR policy v1.1.0 at
c589587395750cd1c79c6fa0bef010189c547249.Authors can now reconstruct historical decisions, draft proposals, append sourced corrections/outcomes, reference governing records and propose replacements. New records remain proposed; human disposition, implementation and verification stay separate. The guidance checks decision impact before implementation and again at completion, and requires an ADR reference or a justified
ADR not requiredhandoff.docs/decisions/; migration is reviewed and reversible.Validation: 199 tests passed with zero skips, including all 11 new ADR tests using the pinned Hygiene source and real EgoLint/Relay runtime, plus the existing native title tests. 205 deterministic evaluation cases passed, including nine ADR examples. Repository, shell, strict staging, catalog/schema/provenance and generated-output checks passed. Two clean builds produced 334 byte-identical files;
gh skill publish dist --dry-runpassed without publishing. The existing preserved staging-hash provenance warning remains.Compatibility limits are explicit in
docs/adr-authoring-adoption.md: selected Holon blueprint 1.0.0 still emits an older policy pin that native validation rejects, so a reviewed owner upgrade precedes materialization. The pinned Hygiene decision-set helper disagrees with EgoLint about pending reciprocal lineage; proposals must preserve the accepted predecessor. Deterministic examples are not model/host execution evidence. Hosted architecture acceptance remains deferred under Relay #99; this does not complete fleet adoption, releases or Aether's later backfill (#85).ADR not required: applies ratified Hygiene ADR-002 within Aether ADR-001/ADR-002/ADR-004 source, ownership and versioning boundaries; introduces no new policy authority, artifact kind or distribution channel.
Closes #91.