Chore: Benchmaxxing sideffect workflow overhead#6
Draft
eersnington wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow overhead benchmarks
Summary
Benchmark Results
Command:
Results:
Notes
56.8msover the fake native baseline at100klocal steps.Effect.succeed(...)from every step added about12.9msover plain Sideffect at100ksteps.Effect.fn("...")in the hot step path was the slowest case at~220ms.Verification
bun run --cwd packages/sideffect bench:workflow-overhead --steps=1000,10000 --samples=3bun run --cwd packages/sideffect bench:workflow-overhead --steps=100000 --samples=3bun run --cwd packages/sideffect bench:workflow-overhead --steps=1000 --samples=1bun run --cwd packages/sideffect testbun run --cwd packages/sideffect checkbun run --cwd packages/sideffect buildbun run checkbun run test